RedditPP Mascot

RedditPP

r/ExperiencedDevs • … • u/tan_nguyen

Is this kind of behavior normal in an enterprise setting?

A bit of background: I have been doing software engineering for about 10 years, working only with startup or scale up companies with about 50-100 engineers in total. And this new job that I have just got is in a big enterprise with few thousands engineers.

I just got my hands on the repo, and the contribution guideline is about 10 pages A4 (approximately) with all the details about... pretty much everything

We are using Typescript, so naturally there is a linter, it is around 400 lines of code (all are custom rules), with a lot of rules about... pretty much everything

The code review process is quite slow (as expected), and people are trying to correct things like: variables should be named this specific way. For example, I used \`const product1 = await getProduct(...)\` in my test, and one of the comment was to change it to \`const previousProduct1 = await getProduct(...)\` because the test title says something about old product. Another example is to follow the order of the function when calling the dependency

const getSomething = (param1, param2, param3) => { // this is the correct order someDep.doGetSomething({ param1, param2, param3 }); // this is the incorrect one according to the code review comment someDep.doGetSomething({ param3, param1, param2 }); }

Another example about naming convention

// incorrect variable name const germanyWarehouseId = ...; // correct variable name const germanWarehouseId = ...;

All of those comments come from 4 different team members so I can assume that this is the team culture to some degree

And my PR usually gets like 60+ comments even if it has about 100-200 changes across 2 or 3 files max (I tend to keep my PR really small).

Another thing is about PR size, my peers tell me to have a big bang PR for new features and small PRs for changing existing features. For example, if we have a new feature, it's better to put everything related to the feature in one PR (I have seen one with around 2000 changes across 20+ files) to make it easier for others to review.

I'm trying to figure out whether this is a normal thing in big enterprises that people want that much consistency / quality in the code base. Because with most companies I have been with so far the PR review usually focuses on the functionality of the code, and most minor things are ignored or briefly mentioned.

— 0